Skip to content

fix(NativeEngineHook): useAppState type error #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2022
Merged

fix(NativeEngineHook): useAppState type error #475

merged 2 commits into from
Oct 12, 2022

Conversation

RodSarhan
Copy link
Contributor

Describe the change

Assert the type of AppState listener remove method to prevent TS type errors on older RN versions

@RodSarhan
fix(NativeEngineHook): useAppState type error
f3a463d 
Assert the type of AppState listener remove method to prevent TS type errors on older RN versions
@RodSarhan RodSarhan mentioned this pull request Oct 11, 2022
Merged
@github-actions
Copy link

Here are the build results
Assembled
Assembled-iOSAndroid0.65
Assembled-iOSAndroid0.69
Assembled-Windows0.65
Assembled-Windows0.69
Artifacts will only be retained for 90 days.

@ryantrem ryantrem enabled auto-merge (squash) October 12, 2022 00:10
@ryantrem ryantrem merged commit 0775d1c into BabylonJS:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RodSarhan @ryantrem @CedricGuillemetMS