Skip to content

Code for SCALA-350 #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Conversation

hkateu
Copy link
Contributor

@hkateu hkateu commented May 13, 2024

Added code for SCALA-350, Refining existing types in Scala with Refined.

@yadavan88
Copy link
Contributor

@hkateu
Could you rebase your branch from the baeldung-master? Some validation has been added to the build recently.
Thanks

@hkateu
Copy link
Contributor Author

hkateu commented May 16, 2024

Hi @yadavan88, i performed a rebase and made the necessary changes.

@yadavan88
Copy link
Contributor

Hi @hkateu
Could you resolve this conflict? I had pushed another change before, and you can take the code from master while resolving conflict. Also, I think that this should have merged before. I will send a ping in the task. Thanks

@hkateu
Copy link
Contributor Author

hkateu commented May 24, 2024

@yadavan88 sorry for the delay, I will work on this today

@yadavan88
Copy link
Contributor

@yadavan88 sorry for the delay, I will work on this today

@yadavan88 sorry for the delay, I will work on this today

No problem. We are doing some refactoring and removing the warnings etc. You can take all changes from upstream for all files except yours. We are doing some refacortoring and removing warnings. This might go on for sometime, and just wanted to avoid causing problems for you again :D

@hkateu hkateu force-pushed the refinevalidation branch from f4d07c1 to 925607c Compare June 2, 2024 12:15
@hkateu
Copy link
Contributor Author

hkateu commented Jun 2, 2024

Hi @yadavan88, sorry for the delay, the checks have passed.

@dominiqueplante dominiqueplante merged commit 0984c30 into Baeldung:master Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants