SCALA-49: Introduction to Optics with Monocole #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonCook
suggested changes
May 21, 2020
There was a problem hiding this comment.
Hi @barbasa
The PR looks OK. I'm sorry but the naming convention has changed for the modules since we began the article. So we'll need to change it to scala-libraries or if you think there could be more articles in this area scala-optics.
There is also a conflict (I guess because of this) in the build.sbt that we need to resolve.
Thanks
|
Hi @JonCook , no problem. Amended the naming convention. |
JonCook
suggested changes
May 27, 2020
scala-libraries/src/test/scala/com/baeldung/scala/monocle/OpticsExamplesUnitTest.scala
Outdated
Show resolved
Hide resolved
scala-libraries/src/test/scala/com/baeldung/scala/monocle/OpticsExamplesUnitTest.scala
Outdated
Show resolved
Hide resolved
scala-libraries/src/main/scala/com/baeldung/scala/monocle/OpticsExamples.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.