bug symfony#9957 [Console] Fixed command name guessing if an alternative is an alias (jakzal)

This PR was merged into the 2.4 branch.

Discussion
----------

[Console] Fixed command name guessing if an alternative is an alias

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#9953
| License       | MIT
| Doc PR        | -

Commits
-------

ade448c [Console] Fixed command name guessing if an alternative is an alias.

Author: fabpot

src/Symfony/Component/Console/Application.php

@@ -562,6 +562,16 @@ public function find($name)
             throw new \InvalidArgumentException($message);
         }
 
+        // filter out aliases for commands which are already on the list
+        if (count($commands) > 1) {
+            $commandList = $this->commands;
+            $commands = array_filter($commands, function ($nameOrAlias) use ($commandList, $commands) {
+                $commandName = $commandList[$nameOrAlias]->getName();
+
+                return $commandName === $nameOrAlias || !in_array($commandName, $commands);
+            });
+        }
+
         $exact = in_array($name, $commands, true);
         if (count($commands) > 1 && !$exact) {
             $suggestions = $this->getAbbreviationSuggestions(array_values($commands));

src/Symfony/Component/Console/Tests/ApplicationTest.php

@@ -393,6 +393,19 @@ public function testFindAlternativeCommands()
         }
     }
 
+    public function testFindAlternativeCommandsWithAnAlias()
+    {
+        $fooCommand = new \FooCommand();
+        $fooCommand->setAliases(array('foo2'));
+
+        $application = new Application();
+        $application->add($fooCommand);
+
+        $result = $application->find('foo');
+
+        $this->assertSame($fooCommand, $result);
+    }
+
     public function testFindAlternativeNamespace()
     {
         $application = new Application();