Skip to content

[Console] Fixed command name guessing if an alternative is an alias #9957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2014

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Jan 6, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #9953
License MIT
Doc PR -

@@ -393,6 +393,19 @@ public function testFindAlternativeCommands()
}
}

public function testFindAlternativeCommandsWithAnAlias()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be singular?

@Seldaek
Copy link
Member

Seldaek commented Jan 6, 2014

Thanks @jakzal :) Just hit this in composer with self-update/selfupdate. Found bad commit. Found this. Happy.

@fabpot
Copy link
Member

fabpot commented Jan 7, 2014

Thank you Jakub for taking care of this regression.

fabpot added a commit that referenced this pull request Jan 7, 2014
…an alias (jakzal)

This PR was merged into the 2.4 branch.

Discussion
----------

[Console] Fixed command name guessing if an alternative is an alias

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9953
| License       | MIT
| Doc PR        | -

Commits
-------

ade448c [Console] Fixed command name guessing if an alternative is an alias.
@fabpot fabpot merged commit ade448c into symfony:2.4 Jan 7, 2014
@jakzal jakzal deleted the bugfix/shortened-command-name-alias branch January 7, 2014 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants