Skip to content

Commit 63653f0

Browse files
committed
Update tests
1 parent f1c3170 commit 63653f0

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

test-e2e/tests/select-multiple.spec.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,13 +246,15 @@ describe(`Choices - select multiple`, () => {
246246
for (let i = 1; i < count + 1; i++) {
247247
await suite.expectVisibleDropdown();
248248
await suite.getChoiceWithText(`Choice ${i}`).click();
249-
await expect(suite.getChoiceWithText(`Choice ${i}`)).toHaveClass(/is-selected/);
250249
await suite.advanceClock();
251250
await suite.expectedItemCount(i);
252-
await expect(suite.selectableChoices).toHaveCount(count);
251+
if (i < count) {
252+
await expect(suite.getChoiceWithText(`Choice ${i}`)).toHaveClass(/is-selected/);
253+
await expect(suite.selectableChoices).toHaveCount(count);
254+
} else {
255+
await suite.expectVisibleNoticeHtml('No choices to choose from');
256+
}
253257
}
254-
255-
await suite.expectVisibleNoticeHtml('No choices to choose from');
256258
});
257259
});
258260

test/scripts/choices.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ describe('choices', () => {
4545
...DEFAULT_CONFIG,
4646
searchEnabled: false,
4747
closeDropdownOnSelect: true,
48+
renderSelectedChoices: false,
4849
});
4950
});
5051
});
@@ -65,6 +66,7 @@ describe('choices', () => {
6566
...DEFAULT_CONFIG,
6667
searchEnabled: false,
6768
closeDropdownOnSelect: true,
69+
renderSelectedChoices: false,
6870
...config,
6971
});
7072
});
@@ -109,7 +111,7 @@ describe('choices', () => {
109111
renderSelectedChoices: 'test' as any,
110112
});
111113

112-
expect(instance.config.renderSelectedChoices).to.equal('auto');
114+
expect(instance.config.renderSelectedChoices).to.equal(false);
113115
});
114116
});
115117
});

test/scripts/templates.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ import { NoticeTypes, Templates as TemplatesInterface } from '../../src/scripts/
1111
*/
1212
function expectEqualElements(element1, element2): void {
1313
expect(element1.tagName).to.equal(element2.tagName);
14-
expect(element1.attributes.length).to.equal(element2.attributes.length);
1514
expect(Object.keys(element1.dataset)).to.have.members(Object.keys(element2.dataset));
1615
expect(element1.classList).to.include(element2.classList);
1716
// compare attributes values
1817
for (const attribute of Object.values(element1.attributes)) {
1918
expect(element1.getAttribute(attribute)).to.equal(element2.getAttribute(attribute));
2019
}
20+
expect(element1.attributes.length).to.equal(element2.attributes.length);
2121
}
2222

2323
function createOptionsWithPartialClasses(classNames: Partial<ClassNames>, options: Partial<Options> = {}): Options {
@@ -563,7 +563,7 @@ describe('templates', () => {
563563
${data.label}
564564
</div>
565565
`);
566-
const actualOutput = templates.choice(choiceOptions, data, itemSelectText);
566+
const actualOutput = templates.choice(choiceOptions, data, itemSelectText, "Group text");
567567

568568
expectEqualElements(actualOutput, expectedOutput);
569569
});

0 commit comments

Comments
 (0)