Implemented reading values of SimpleAggregateFunction #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enmk
force-pushed
the
SimpleAggregateFunction
branch
from
6f27d43 to
5800488
Compare
traceon
reviewed
Aug 2, 2020
ut/columns_ut.cpp
Outdated
| @@ -258,3 +259,11 @@ TEST(ColumnsCase, LowCardinalityString_Save) { | |||
| EXPECT_EQ(col.At(i), foobar(i)) << " at pos: " << i; | |||
| } | |||
| } | |||
|
|
|||
| TEST(ColumnsCase, CreateSimpleAggregateFunction) { | |||
| auto col = CreateColumnByType("SimpleAggregateFunction(funt, Int32"); | |||
There was a problem hiding this comment.
SimpleAggregateFunction(funt, Int32 (without closing parentheses)? Does this test pass? If yes, then why? Should it pass (i.e. should type parser tolerate this)?
| "ENGINE = Memory"); | ||
|
|
||
| constexpr size_t EXPECTED_ROWS = 10; | ||
| client_->Execute("INSERT INTO test_clickhouse_cpp.SimpleAggregateFunction (saf) SELECT number FROM system.numbers LIMIT 10"); |
There was a problem hiding this comment.
I would say ... LIMIT " + std::to_string(EXPECTED_ROWS));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Columns of
SimpleAggregateFunction(func, X)are now handled properly and can be read from client's code as Column-X.