Add DateTime64 data type. #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enmk
force-pushed
the
DateTime64
branch
3 times, most recently
from
ed1a8ea to
97c4cb9
Compare
…ers for Decimals and DateTime64
…ers for Decimals and DateTime64
…tegration tests Fixed DateTime64 example
traceon
approved these changes
Sep 11, 2020
| TYPED_TEST_P(ColumnPerformanceTest, SaveAndLoad) { | ||
| SKIP_IN_DEBUG_BUILDS(); |
There was a problem hiding this comment.
FYI, Google Test has GTEST_SKIP() starting from some version, and, alternatively, you can prepend DISABLED_ to the name of a test to disable it (should be available in the bundled gtest repo). Not an issue here, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #38
New Column type:
ColumnDateTime64Sligtly updated some underlying code
Added unit and integrration tests for ColumnDateTime64
Closes #38