Skip to content

Add getBestBlockId RPC method #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 5, 2018
Merged

Add getBestBlockId RPC method #320

merged 5 commits into from
Jul 5, 2018

Conversation

kakao-jun-e
Copy link
Contributor

Fixed #290

@joojis
Copy link
Contributor

joojis commented Jul 4, 2018

@redongjun Could you update the spec file along with?

https://github.com/CodeChain-io/codechain/blob/master/spec/JSON-RPC.md#chain_getbestblockid

@kakao-jun-e
Copy link
Contributor Author

kakao-jun-e commented Jul 4, 2018 •
edited
Loading

@joojis it's OK

Could you know me why the order of field (hash and number) is reversed on a RPC response as below?

{"jsonrpc":"2.0","result":{"hash":"0x5559d68fc86a3088383bc83a8ed0b092523e578283a0260eb0cec5832a0006ea","number":0},"id":null}

@joojis
Copy link
Contributor

joojis commented Jul 4, 2018

@redongjun I was unintentional for that. You can change the order in the spec.

@kakao-jun-e kakao-jun-e force-pushed the release/bestblockid branch from f030ef6 to 6fc2ffe Compare July 4, 2018 11:32
@joojis joojis self-requested a review July 5, 2018 01:21
joojis
joojis reviewed Jul 5, 2018
View reviewed changes
spec/JSON-RPC.md
@@ -149,7 +149,7 @@ Response Example
```

## chain_getBestBlockId
(not implemented yet) Gets the number and the hash of the best block.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is 1 more "not implemented" note in the List of Methods (line 84)

@kakao-jun-e kakao-jun-e force-pushed the release/bestblockid branch from 64adffe to f20f841 Compare July 5, 2018 04:32
joojis
joojis approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@joojis joojis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joojis joojis merged commit 1a3c98c into CodeChain-io:master Jul 5, 2018
@kakao-jun-e kakao-jun-e deleted the release/bestblockid branch July 6, 2018 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joojis joojis joojis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kakao-jun-e @joojis @kseo @sgkim126