-
Notifications
You must be signed in to change notification settings - Fork 51
Add Stratum specification #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
spec/Stratum.md
Outdated
|
||
## mining.authorize | ||
|
||
Used for authorizing miner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miner -> miners
spec/Stratum.md
Outdated
|
||
## mining.notify | ||
|
||
Used for sending notifications with mining jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used for sending notifications with mining jobs -> Used for sending notifications regarding mining jobs.
spec/Stratum.md
Outdated
``` | ||
|
||
## Exception Handling (DRAFT) | ||
Stratum defines simple exception handling. Example of rejected share looks like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example of rejected share looks like: -> Example of a rejected share looks like:
spec/Stratum.md
Outdated
``` | ||
|
||
Where the error field is defined as (error_code, human_readable_message, traceback). Traceback may contain additional information for debugging errors. | ||
Proposed error codes for mining service are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mining service -> mining services
spec/Stratum.md
Outdated
} | ||
``` | ||
|
||
Where the error field is defined as (error_code, human_readable_message, traceback). Traceback may contain additional information for debugging errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traceback may contain additional information about debugging errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested some changes for descriptions.
bc83d78
to
c270ebf
Compare
I've added "CLI options". |
c270ebf
to
7a49295
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #479