Skip to content

Add WebSocket support to JSON-RPC #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2018
Merged

Add WebSocket support to JSON-RPC #725

merged 1 commit into from
Sep 21, 2018

Conversation

kakao-jun-e
Copy link
Contributor

Fix #225

I have tested it as follows :

$ wscat -c 127.0.0.1:8081
connected (press CTRL+C to quit)
> {"jsonrpc": "2.0", "method": "ping", "params": [], "id": null}
< {"jsonrpc":"2.0","result":"pong","id":null}

@kakao-jun-e kakao-jun-e force-pushed the jsonrpc_ws branch 4 times, most recently from 7190622 to 2ef5e2a Compare September 16, 2018 00:53
@sgkim126 sgkim126 added the rpc label Sep 17, 2018
@sgkim126 sgkim126 requested a review from kseo September 17, 2018 07:07
@kseo
Copy link
Member

kseo commented Sep 19, 2018

@redongjun Would you resolve the conflicts first?

kseo
kseo requested changes Sep 19, 2018
View reviewed changes
codechain/codechain.yml Outdated
@@ -281,4 +306,3 @@ subcommands:
help: Address of desired password change
required: true
index: 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary change.

codechain/rpc.rs Outdated
},
Err(e) => Err(format!("WebSockets error: {:?}", e)),
Ok(server) => {
info!("WebSockets Listening on {}", addr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use cinfo! macro. There is RPC log target.

kseo
kseo approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@kseo kseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kseo kseo merged commit 93d3c63 into CodeChain-io:master Sep 21, 2018
@kakao-jun-e kakao-jun-e deleted the jsonrpc_ws branch September 27, 2018 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kseo kseo kseo approved these changes

Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kakao-jun-e @kseo @sgkim126