Skip to content

[bug] Remove Arr::wrap for arguments to solve bug #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

Jaspur
Copy link
Contributor

@Jaspur Jaspur commented Aug 1, 2022

Issue: #237

What I did

Fixes #237

  • Does this need an update to the documentation?
    No

@Jaspur
Copy link
Contributor Author

Jaspur commented Aug 1, 2022

@CodeDredd , II don't know why you wanted to Arr::wrap that part, but without it, it works without bugs.

@CodeDredd
Copy link
Owner

CodeDredd commented Aug 4, 2022

I thought that way it wouldnt brake. But it seems that i was wrong. Initially it started with another bug. See #233

Anyway thanks for the pr! Looking into it...but i think you have to implement somethink more.

I think i add an option to decide how its handled.

@CodeDredd CodeDredd added the bug Something isn't working label Aug 4, 2022
@CodeDredd CodeDredd merged commit 313e060 into CodeDredd:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error sending arguments
2 participants