Skip to content

Laravel 10.x Compatibility #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-soap.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "codedredd/laravel-soap": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@stale
Copy link

stale bot commented Mar 18, 2023

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 18, 2023
@bretto36
Copy link
Contributor

@CodeDredd Any chance of this getting merged? We are wanting to use L10 and seems to have issues with the illuminate stuff

Problem 1
- Root composer.json requires codedredd/laravel-soap ^3.0.2 -> satisfiable by codedredd/laravel-soap[v3.0.2].
- Only one of these can be installed: illuminate/contracts[v5.0.0, ..., v5.8.36, v6.0.0, ..., v6.20.44, v7.0.0, ..., v7.30.6, v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.6, v10.0.0, ..., v10.8.0], laravel/framework[v10.8.0]. laravel/framework replaces illuminate/contracts and thus cannot coexist with it.
- codedredd/laravel-soap v3.0.2 requires illuminate/contracts ^9.0 -> satisfiable by illuminate/contracts[v9.0.0, ..., v9.52.6].
- Root composer.json requires laravel/framework ^10.8 -> satisfiable by laravel/framework[v10.8.0].

@stale stale bot removed the inactive label Apr 20, 2023
@CodeDredd
Copy link
Owner

@bretto36 Have you tried the new version?
I merged already an 10.x PR. But i am merging this too. Just need to verify if the changes are correct now

@CodeDredd CodeDredd merged commit 39a7e2e into CodeDredd:master Apr 20, 2023
@bretto36
Copy link
Contributor

@CodeDredd ah i had to be explicit to use the -beta branch in my composer json file. Laravel changed minimum stability to "stable" as the default

Thank you for attending to my query so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants