Skip to content

Move codeigniter4/framework to require-dev #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

samsonasik
Copy link
Contributor

To avoid dependabot error in CodeIgniter 4 repo, see https://github.com/codeigniter4/CodeIgniter4/network/updates/953278072

@samsonasik
Copy link
Contributor Author

/cc @paulbalandan

@paulbalandan
Copy link
Collaborator

I'm currently understanding the issue, but sure let's merge this for now.

@samsonasik
Copy link
Contributor Author

I added to conflict for avoid install before 4.5

@paulbalandan
Copy link
Collaborator

I added to conflict for avoid install before 4.5

Can you tell me why?

@samsonasik
Copy link
Contributor Author

this ensure current check equal, but it still installable on CodeIgniter 4, if user try to install in codeigniter <4.5, it can't, but doesn't necessarily to require it.

this is what I do on my module, eg can use opt in doctrine functinality, but when user do, user needs to use specific doctrine version

https://github.com/samsonasik/ErrorHeroModule/blob/2908ad29ced8d8eb5fbd48850c9efc75abb9931d/composer.json#L51-L59

Of course, I can revert it if it doesn't necessarily needed.

@samsonasik
Copy link
Contributor Author

it may related with self.version usage on CodeIgniter4 repo https://github.com/codeigniter4/CodeIgniter4/blob/b5e9715518186a9f4a98deeac1587b1131d01f8b/composer.json#L35

@samsonasik
Copy link
Contributor Author

@paulbalandan do you think conflict config is not needed for codeigniter 4.5 ?

@paulbalandan
Copy link
Collaborator

The move to require was made here 530b659, so 1 year has passed and this issue arises so it may be coming from composer.

I'll merge this let's see what happens.

@paulbalandan paulbalandan merged commit d7c525e into CodeIgniter:1.x Jan 24, 2025
9 checks passed
@samsonasik samsonasik deleted the patch-1 branch January 24, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants