-
Notifications
You must be signed in to change notification settings - Fork 62
Fix server auto-restart logic on domain reloading #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix server auto-restart logic on domain reloading #25
Conversation
📝 WalkthroughWalkthroughThe static constructor of the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good change
true that this delaycall is unecessary as InitializeOnLoad is invoked from the main thread
Probrem
The WebSocket server is not restarted after domain reloading (e.g., compiled).
Conditions:
The Unity editor does not have focus.
Fixes
Removed unnecessary use of
EditorApplication.delayCall
.delayCall
isIf the Unity Editor does not have focus, the Inspector will not be updated, and
delayCall
will not be executed.refs https://docs.unity3d.com/ScriptReference/EditorApplication-delayCall.html
refs #18
Summary by CodeRabbit