Skip to content

Added noise videos to noise track for issue #1407 #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 5, 2024

Conversation

lcgraves
Copy link
Contributor

@lcgraves lcgraves commented Apr 4, 2024

I also added three missing thumbnail images for older showcase contributions (issue # 1057).

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for codingtrain ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1e62fd4
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/66338bdbb58da100088295d5
😎 Deploy Preview https://deploy-preview-1551--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfahn22
Copy link
Collaborator

kfahn22 commented Apr 10, 2024

@lcgraves Thank you so much for adding the noise videos and images!!! I have left some suggestions to help you edit the pull request so that it will pass the tests (I left the fixes for only one of the files, the comments about timecodes and credits applies to both). You can also run nom run test in terminal to see what the problems are.

You will also need to edit the index.json file for the NOC track and add the videos so they will show on the website:

content/tracks/main-tracks/the-nature-of-code-2/index.json

{
"title": "Perlin Noise and p5.js Tutorial",
"videos": ["noc/perlin/intro-to-perlin-noise", "noc/perlin/noise-vs-random", "noc/perlin/graphing-1d-perlin-noise", "noc/perlin/perlin-noise-2d", "noc/perlin/perlin-noise-detail"]
},

If you have any questions please let me know. Again, thank you so much for contributing!

@shiffman
Copy link
Member

Hi @lcgraves, wow, thank you for this wonderful contribution! Please let us know if you would like to finish any changes to this branch or if you prefer @kfahn22 or I can make final adjustments so it can be merged.

Thank you for taking the time, and for your patience for me to review!

shiffman and others added 2 commits April 20, 2024 09:39
add related challenges, , first timestamp,  and credits
switch order of videos so they are in numerical order
@shiffman
Copy link
Member

shiffman commented May 2, 2024

@kfahn22 thanks for updating this! Is it ready for me to merge?

@shiffman
Copy link
Member

shiffman commented May 2, 2024

@all-contributors add @lcgraves for content

Copy link
Contributor

@shiffman

I've put up a pull request to add @lcgraves! 🎉

@kfahn22
Copy link
Collaborator

kfahn22 commented May 2, 2024

Yes, I believe it is ready to merge.

@shiffman shiffman merged commit f71c7ff into CodingTrain:main May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants