-
Notifications
You must be signed in to change notification settings - Fork 120
Added noise videos to noise track for issue #1407 #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I took a screenshot of the project in the correct aspect ratio 16:9 (800px x 450px)
content/videos/challenges/1-starfield/showcase/contribution5.json
content/videos/challenges/101-may-the-4th-scrolling-text/showcase/contribution1.json
✅ Deploy Preview for codingtrain ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@lcgraves Thank you so much for adding the noise videos and images!!! I have left some suggestions to help you edit the pull request so that it will pass the tests (I left the fixes for only one of the files, the comments about timecodes and credits applies to both). You can also run You will also need to edit the index.json file for the NOC track and add the videos so they will show on the website: content/tracks/main-tracks/the-nature-of-code-2/index.json { If you have any questions please let me know. Again, thank you so much for contributing! |
add related challenges, , first timestamp, and credits switch order of videos so they are in numerical order
@kfahn22 thanks for updating this! Is it ready for me to merge? |
@all-contributors add @lcgraves for content |
I've put up a pull request to add @lcgraves! 🎉 |
Yes, I believe it is ready to merge. |
I also added three missing thumbnail images for older showcase contributions (issue # 1057).