Skip to content

Add Multiple Examples to Video Showcase #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 5, 2025
Merged

Conversation

vislupus
Copy link
Contributor

This pull request includes the following updates:

  • Replaced the image in an existing example to enhance clarity and visual appeal.
  • Added a new example to provide additional context and better illustrate the concept.

These changes aim to improve the user experience by making the showcased content more engaging and informative.

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for codingtrain ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f1f503
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/67a3656add8ed30008986dc8
😎 Deploy Preview https://deploy-preview-1794--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vislupus vislupus changed the title Update to "1-What-Is-a-Vector" Video Showcase Add Multiple Examples to Video Showcase Jan 10, 2025
@vislupus
Copy link
Contributor Author

Added more new examples to enhance the section and provide broader context.

@shiffman
Copy link
Member

Hi @vislupus, apologies for the delay in reviewing this. So many wonderful examples and demos, I'm so impressed by your work! It looks like in a couple instances, the same sketch is submitted for multiple videos. Unfortunately the site doesn't really support this right now and rather than have duplicate entries I think it's best to pick the video that is "best suited" to each project. Does this make sense? Would you mind editing this pull request so each project is submitted only once?

@shiffman shiffman added the showcase Passenger Showcase Submission label Jan 20, 2025
@vislupus
Copy link
Contributor Author

vislupus commented Feb 5, 2025

Hi @shiffman, I removed the duplicated examples and now it should be ok.

@shiffman
Copy link
Member

shiffman commented Feb 5, 2025

Amazing, thank you!!

@shiffman shiffman merged commit 8438fca into CodingTrain:main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Passenger Showcase Submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants