Skip to content

DOC: Update install docs [ci skip] #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2018
Merged

DOC: Update install docs [ci skip] #29

merged 4 commits into from
May 17, 2018

Conversation

TomAugspurger
Copy link
Contributor

[ci skip]

@TomAugspurger TomAugspurger mentioned this pull request May 17, 2018
Closed
xhochy
xhochy suggested changes May 17, 2018
View reviewed changes
setup.cfg Outdated
@@ -1,5 +1,5 @@
[bdist_wheel]
universal=1
universal=0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the wrong approach. The wheel should be universal but the setup.py should not use

cyberpandas/setup.py

Lines 13 to 14 in bad804b

if sys.version_info.major == 2:
install_requires.append('ipaddress')
but rather apply environment markers: ipaddress; python_version < '3'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, thanks. That seemed to work locally.

@TomAugspurger TomAugspurger merged commit 2bfb706 into ContinuumIO:master May 17, 2018
@TomAugspurger
Copy link
Contributor Author

Thanks @xhochy.

@TomAugspurger TomAugspurger deleted the install-update branch May 17, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAugspurger @xhochy