Skip to content

Add git to prepare performance testing #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Add git to prepare performance testing #332

merged 4 commits into from
Jan 24, 2023

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Jan 6, 2023

What does this PR do?

Add git to Dockerfile to allow installing specific dd-trace version (by git hash)

Motivation

Prepare for performance testing

Testing Guidelines

CI should pass

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@maxday maxday marked this pull request as ready for review January 6, 2023 13:44
@maxday maxday requested a review from a team as a code owner January 6, 2023 13:44
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #332 (f2676e4) into main (73cd8aa) will not change coverage.
The diff coverage is n/a.

❗ Current head f2676e4 differs from pull request most recent head 43ee833. Consider uploading reports for the commit 43ee833 to get more accurate results

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files          36       36           
  Lines        1807     1807           
  Branches      418      418           
=======================================
  Hits         1428     1428           
  Misses        326      326           
  Partials       53       53           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxday maxday merged commit 0ea4417 into main Jan 24, 2023
@maxday maxday deleted the maxday/add-git branch January 24, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants