Skip to content

Postgresql: Declare the same setting for nulls in indexes as in order by statement #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Postgresql: Declare the same setting for nulls in indexes as in order by statement #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79981d1
Postgresql: Declare the same setting for nulls in indexes as in order…
alex-kulakov Jan 22, 2025
06d0f1c
Improve changelog
alex-kulakov Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ChangeLog/7.1.4_dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
[main] Addressed IndexOutOfRangeException on translation of certain queries with aggregates
[main] Notification to BuildLog when a hierarchy changes KeyGeneratorKind value to None
[main] Notification to BuildLog when a hierarchy changes KeyGeneratorKind value to None
[postgresql] Added explicit nulls setting for both column order directions to improve OrderBy/OrderByDescending performance
3 changes: 3 additions & 0 deletions Orm/Xtensive.Orm.PostgreSql/Sql.Drivers.PostgreSql/v9_0/Translator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ public override void Translate(SqlCompilerContext context, object literalValue)
}
}

public override void TranslateSortOrder(IOutput output, bool ascending) =>
output.Append(ascending ? "ASC NULLS FIRST" : "DESC NULLS LAST");

// Constructors

public Translator(SqlDriver driver)
Expand Down