Merge latest official repo #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer necessary since pytest-catchlog has been merged into pytest's core. This commit addresses the following warning in pytest output: pytest-catchlog plugin has been merged into the core, please remove it from your requirements. Fixes dpkp#1379
* Use hardware accelerated CRC32C function if available * Add doc notice of optional `crc32c` package
If a future was passed as the only positional parameter it would be assigned to the "timeout_ms" parameter erroneously. This mistake would not raise any exception but would lead to odd behaviour later, what could make it extremely difficult to troubleshoot. Adding a type check ensures that an exception is raise earlier to notify the user about the problem.
This commits adds new pytest fixtures in prepation for the migration of unittest.TestCases to pytest test cases. The handling of temporary dir creation was also changed so that we can use the pytest tmpdir fixture after the migration.
Change-Id: I6527da4b70ebec9e08fa50aca9eba717b8361f19
In Python3, `ConnectionError` is a native exception. So rename our custom one to `KafkaConnectionError` to prevent accidentally shadowing the native one. Note that there are still valid uses of `ConnectionError` in this code. They already expect a native Python3 `ConnectionError`, and also already handle the Python2 compatibility issues.
If a valid broker in the cluster has no partitions, it will return None rather than an empty set. Similarly updated a few other methods.
* only perform single dns lookup for connect_blocking() * fix blocking timeout in check_version()
This finishes the split from `kafka.common` to `kafka.errors`/`kafka.structs`.
This solves a warning in linters like PyCharm, which warns that a line like: from kafka import ConsumerRebalanceListener is actually accessing a protected member of a class or module. Adding it to __all__ should solve this.
stephenhenderson
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.