Skip to content

Remove directory from config.php example #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Remove directory from config.php example #131

merged 1 commit into from
Sep 13, 2021

Conversation

Metacinnabar
Copy link
Contributor

Description

Removes the directory comment from the config.php code block example due to the # character causing php to fail to display the web page.

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

Checklist:

  • I have checked to make sure no other pull requests are open for this issue

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I never actually intended for the comment to be placed the file.

It's more of a direction to the reader where to put it which is already explained in the sentence above.

It could be replaced with <!-- /src/config.php -->, but as noted above, it's probably not necessary at all.

@Metacinnabar
Copy link
Contributor Author

Probably not seeing as you explain the directory to put it in in the comment above.

@DenverCoder1 DenverCoder1 merged commit 147b68e into DenverCoder1:main Sep 13, 2021
@DenverCoder1
Copy link
Owner

Thanks for contributing! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants