Skip to content

Date Format Customization #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 3, 2021
Merged

Conversation

lucid-dreem
Copy link
Contributor

Description

Added a Date Format field to allow for customization based on 4 options. Tried to use the text box alternative but it seemed like it would be a better option to use the dropdown and have a text box as one of the Advanced Options if required. No changes have been made to the Advanced Options in this pull request.

Fixes #134

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Screenshot 2021-10-01 at 8 20 29 PM

@DenverCoder1
Copy link
Owner

Looks good, maybe make the option text show examples of the date format instead of the format string to make it easier to use:

eg.

<option value="M j[, Y]">Apr 14 / Apr 14, 2021</option>

Also, the options don't have to be the examples in the readme, maybe pick a few common formats like one with month day year, one day month year, one year month day, maybe one with dots, one with slashes, etc.

lucid-dreem and others added 2 commits October 3, 2021 08:19
Co-authored-by: Jonah Lawrence <[email protected]>
Co-authored-by: Jonah Lawrence <[email protected]>
@DenverCoder1 DenverCoder1 merged commit 2871375 into DenverCoder1:main Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add date_format to the demo site
2 participants