Skip to content

Add favicons #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2021
Merged

Add favicons #150

merged 1 commit into from
Oct 3, 2021

Conversation

Lilfaen
Copy link
Contributor

@Lilfaen Lilfaen commented Oct 3, 2021

Description

Added favicons to demo page

Fixes #143

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Tested on Safari 15.0, Edge 94.0.992.38, Firefox 92.0.1.

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Safari tab
Screenshot 2021-10-03 at 15 14 38

Edge Tab
Screenshot 2021-10-03 at 14 59 21

Safari Bookmark
Screenshot 2021-10-03 at 15 00 22

Edge Bookmark
Screenshot 2021-10-03 at 15 01 18

Copy link
Contributor

@Evavic44 Evavic44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@DenverCoder1
Copy link
Owner

Thanks for contributing!

@DenverCoder1 DenverCoder1 merged commit 33c61f0 into DenverCoder1:main Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add favicon
3 participants