Skip to content

feat: added hindi translation #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2022
Merged

feat: added hindi translation #268

merged 1 commit into from
Jul 4, 2022

Conversation

tejas-nagchandi
Copy link
Contributor

Description

Fixes # 236

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

DenverCoder1
DenverCoder1 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Jul 4, 2022
@DenverCoder1 DenverCoder1 changed the title Issue #236 added hindi translation feat: added hindi translation Jul 4, 2022
@DenverCoder1 DenverCoder1 merged commit 508c946 into DenverCoder1:main Jul 4, 2022
@tejas-nagchandi tejas-nagchandi deleted the hi branch July 4, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejas-nagchandi @DenverCoder1