Skip to content

feat: Add yellowdark theme #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from Jul 22, 2022
Merged

feat: Add yellowdark theme #274

merged 6 commits into from Jul 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 8, 2022

Description

Added new yellowdark theme.

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

With border

image

Without border

image

This are a screenshots from the demo site.

@DenverCoder1 DenverCoder1 added enhancement New feature or request new theme adding a new theme labels Jul 20, 2022
@DenverCoder1
Copy link
Owner

I find this pallete to be a bit similar to javascript-dark and great-gatsby but I feel the primary red seems to stand out a lot.

Maybe a shade of orange for the fire could be better, or possibly a duller red or matching yellow?

Feel free to let me know what you think. 👍

Additionally, the image for the docs can be obtained by doing a right-click on the picture on the demo site and copy in order to avoid having the extra white-space around the border.

@ghost
Copy link
Author

ghost commented Jul 21, 2022

Perhaps. I'll try to change the color of the fire.

Thanks for the advice!

@ghost
Copy link
Author

ghost commented Jul 21, 2022

How about this?

image

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Jul 21, 2022

Looks good 👍

I'll merge it when the code and docs are updated.

@ghost
Copy link
Author

ghost commented Jul 22, 2022

Okay.

@ghost
Copy link
Author

ghost commented Jul 22, 2022

I have updated the code and docs.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Add yellowdark theme feat: Add yellowdark theme Jul 22, 2022
@DenverCoder1 DenverCoder1 merged commit 4359384 into DenverCoder1:main Jul 22, 2022
@ghost ghost deleted the yellowdark branch July 22, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new theme adding a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant