Skip to content

fix(demo): Move locale above date format #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

DenverCoder1
Copy link
Owner

Description

Moved Locale field above Date format field in the demo site.

This order makes more sense since changing the Locale effects the default setting for date format so should be changed first to know what the default actually will look like. If the date format is changed first, the internationalized date format won't be seen by the user.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-move-local-oyoqbo August 7, 2022 15:12 Inactive
@DenverCoder1 DenverCoder1 merged commit 12ea9d8 into main Aug 7, 2022
@DenverCoder1 DenverCoder1 deleted the move-locale-before-date-format branch August 7, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant