Skip to content

feat: Wrap long lines and allow for two-line translation strings #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 16, 2022

Conversation

DenverCoder1
Copy link
Owner

Description

Allows for 2-line translations and splits range text at " - " if the line exceeds 28 characters.

Translated labels will automatically split at 22 (bold) / 24 characters.

Newlines may be inserted manually in translations.php to override the max chars effect, eg. "Total\nContributions")

Before
image

After
image

Before
image

After
image

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-multiline--ofbsgx October 16, 2022 04:08 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-multiline--ofbsgx October 16, 2022 04:08 Inactive
@DenverCoder1 DenverCoder1 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Oct 16, 2022
@DenverCoder1 DenverCoder1 changed the title feat: Allow for two-line translation strings feat: Wrap long lines and allow for two-line translation strings Oct 16, 2022
@DenverCoder1 DenverCoder1 merged commit 56db25c into main Oct 16, 2022
@DenverCoder1 DenverCoder1 deleted the multiline-translations branch October 16, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant