Skip to content

fix: replace wordwrap to support utf8 words #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2022
Merged

Conversation

DenverCoder1
Copy link
Owner

Description

Previously the wordwrap would cause display issues with text such as "மிக சமீபத்திய தொடர்ச்சியான பங்களிப்புகள்"

This implementation works better with other languages

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 added the bug Something isn't working label Oct 16, 2022
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-utf8-wordw-3bun8x October 16, 2022 04:56 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-utf8-wordw-3bun8x October 16, 2022 04:59 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-utf8-wordw-3bun8x October 16, 2022 05:04 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-utf8-wordw-3bun8x October 16, 2022 05:08 Inactive
@DenverCoder1 DenverCoder1 merged commit c2074ea into main Oct 16, 2022
@DenverCoder1 DenverCoder1 deleted the utf8-wordwrap branch October 16, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant