feat: Added modern-lilac and modern-lilac2 themes #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks great!
It would also be nice if you could update the docs/themes.md as well on your branch.
https://user-images.githubusercontent.com/20955511/197569406-6ff144c3-1d6e-4500-9f0b-3112a6c62584.png
Here is an image URL you can use.
Co-authored-by: Jonah Lawrence <[email protected]>
|
Hi, I thought it would be nice if there is a second theme where the text is white, so I made it under modern-lilac2. If you send me again such an image, I will add this theme also to the doc so that you can merge this PR. |
|
The image is from the demo site
|
|
Did it, you can merge!!!! |
DenverCoder1
approved these changes
Oct 24, 2022
DenverCoder1
changed the title
DenverCoder1
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the best theme ever!!!!!
Actually it's my personal theme, but I use it all the time and I think it belongs here too.
Type of change
How Has This Been Tested?
With the attribute thing in the link
Checklist: