Skip to content

Submarine Flowers Theme #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2022

Conversation

jesterb0206
Copy link
Contributor

Description

Hi Jonah,

I was able to successfully edit themes.php to add my new theme colors and I brew installed PHP and Composer so I could test my theme locally. It successfully ran and after a couple of additional commits (sorry for making 2 commits for my docs/themes.md entry) and a lot of head scratching I think I was able to finally add my theme correctly!

Fixes # 350

Type of change

Added a new theme for GitHub README Streak Stats!

How Has This Been Tested?

  • Tested locally with a valid username

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

^ I didn't comment out my code or make changes to the documentation because they aren't applicable here.

Screenshots

Here's the static PNG image of my theme that I added to docs/themes.md

submarine-flowers-static-theme-img

@DenverCoder1 DenverCoder1 added new theme adding a new theme no-issue-activity No activity in 30+ days and removed no-issue-activity No activity in 30+ days labels Nov 13, 2022
@DenverCoder1 DenverCoder1 linked an issue Nov 13, 2022 that may be closed by this pull request
1 task
Jonah fixed the Prettier lint issue and made the URL consistent with the other ones in themes.md

Co-authored-by: Jonah Lawrence <[email protected]>
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit e69b386 into DenverCoder1:main Nov 13, 2022
@jesterb0206
Copy link
Contributor Author

Thank you so much!

@jesterb0206 jesterb0206 deleted the submarine-flowers-theme branch November 13, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new theme adding a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submarine Flowers (New Theme Idea)
2 participants