Skip to content

feat: Added translations for Arabic, Bangla, Hindi, Spanish #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 4, 2022
Merged

feat: Added translations for Arabic, Bangla, Hindi, Spanish #371

merged 6 commits into from
Dec 4, 2022

Conversation

robloxiandemo
Copy link
Contributor

@robloxiandemo robloxiandemo commented Dec 2, 2022

Description

  • Added in Arabic translations;
  • Fixed and finished up the Bangla translations;
  • Finished up the Hindi translations;
  • Finished up the Spanish translations.

Type of change

  • Arabic translations;
  • Bangla translations;
  • Hindi translations;
  • Spanish translations.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translations look good to me 👍

I have one comment about rtl support though

@DenverCoder1 DenverCoder1 changed the title feat: Add multiple translations. feat: Added translations for Arabic, Bangla, Hindi, Spanish Dec 2, 2022
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-main-ap5sd02gpnmv December 2, 2022 18:22 Inactive
@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Dec 2, 2022
Add right -> left support.

Co-authored-by: Jonah Lawrence <[email protected]>
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-main-nekijuna4dfm December 4, 2022 04:44 Inactive
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit f37e800 into DenverCoder1:main Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants