-
Notifications
You must be signed in to change notification settings - Fork 26
Update of the basics of DML article; new score for PLIV; adaption due to changed API of DoubleMLPLR & DoubleMLPLIV #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_l and additional IV-type score for PLIV
|
PhilippBach
reviewed
Jun 9, 2022
PhilippBach
reviewed
Jun 9, 2022
PhilippBach
reviewed
Jun 9, 2022
PhilippBach
reviewed
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MalteKurz for preparing this PR which includes a lot of changes regarding the (names) of the nuisance learners as well as the example in the basics chapter. I only have a minor comment/suggestion for the plots in R there
Co-authored-by: PhilippBach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
IV-type
for the PLIV model (see Python: Adapt nuisance est forIV-type
score (PLR) & new scoreIV-type
for PLIV doubleml-for-py#151 and R: Adapt nuisance est forIV-type
score (PLR) & new scoreIV-type
for PLIV doubleml-for-r#161)IV-type
score (PLR) & new scoreIV-type
for PLIV doubleml-for-py#151 and R: Adapt nuisance est forIV-type
score (PLR) & new scoreIV-type
for PLIV doubleml-for-r#161)