Skip to content

Adapt to sklearn 1.1.0 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2022
Merged

Adapt to sklearn 1.1.0 #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d5985
error message was changed in sklearn==1.1.0 (https://github.com/sciki…
MalteKurz May 13, 2022
80d6c9c
error message was changed in sklearn==1.1.0
MalteKurz May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doubleml/tests/test_dml_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ def test_dml_data_w_missings(generate_data_irm_w_missings):
_ = DoubleMLData.from_arrays(x, y, d,
force_all_x_finite='allow-nan')

msg = r"Input contains NaN, infinity or a value too large for dtype\('float64'\)."
msg = r"Input contains NaN."
with pytest.raises(ValueError, match=msg):
_ = DoubleMLData.from_arrays(x, y, d,
force_all_x_finite=True)
Expand Down Expand Up @@ -504,7 +504,7 @@ def test_dml_data_w_missings(generate_data_irm_w_missings):
y_col='y', d_cols='d',
force_all_x_finite='allownan')

msg = r"Input contains NaN, infinity or a value too large for dtype\('float64'\)."
msg = r"Input contains NaN."
with pytest.raises(ValueError, match=msg):
dml_data.force_all_x_finite = True

Expand Down
2 changes: 1 addition & 1 deletion doubleml/tests/test_irm_with_missings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,6 @@ def test_irm_exception_with_missings(generate_data_irm_w_missings, learner_sklea
dml_irm_obj = dml.DoubleMLIRM(obj_dml_data,
ml_g, ml_m)

msg = r"Input contains NaN, infinity or a value too large for dtype\('float64'\)."
msg = r"Input X contains NaN.\nLinearRegression does not accept missing values encoded as NaN natively."
with pytest.raises(ValueError, match=msg):
dml_irm_obj.fit()