Skip to content

Extend Default Setting Unit Tests and check propensities #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2023
Merged

Extend Default Setting Unit Tests and check propensities #183

merged 4 commits into from
Jan 20, 2023

Conversation

SvenKlaassen
Copy link
Member

@SvenKlaassen SvenKlaassen commented Jan 6, 2023 •
edited
Loading

Description

Extend the unit tests for the default parameters of the methods fit(), bootstrap(), confint() and p_adjust().
Further, add _check_is_propensity() to utils to check, whether propensites are in (0,1).

Reference to Issues or PRs

#150
#129

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@SvenKlaassen SvenKlaassen linked an issue Jan 6, 2023 that may be closed by this pull request
[Unit Test Extension]: Extend "default setting unit tests" to methods #150
Closed
@SvenKlaassen SvenKlaassen linked an issue Jan 9, 2023 that may be closed by this pull request
Check estimated propensity scores #129
Closed
@SvenKlaassen SvenKlaassen changed the title Extend Default Setting Unit Tests Extend Default Setting Unit Tests and check propensities Jan 9, 2023
@SvenKlaassen SvenKlaassen linked an issue Jan 11, 2023 that may be closed by this pull request
[Bug]: KeyError in DoubleMLPLIV.fit() with multiple instruments and store_predictions=True #184
Closed
@SvenKlaassen SvenKlaassen removed a link to an issue Jan 11, 2023
[Bug]: KeyError in DoubleMLPLIV.fit() with multiple instruments and store_predictions=True #184
Closed
@SvenKlaassen SvenKlaassen marked this pull request as ready for review January 20, 2023 09:10
@SvenKlaassen SvenKlaassen merged commit 32298ee into main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unit Test Extension]: Extend "default setting unit tests" to methods Check estimated propensity scores
1 participant
@SvenKlaassen