-
Notifications
You must be signed in to change notification settings - Fork 93
Add Sensitivity Analysis #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add g_hat1 estimation to ATTE to simplify sensitivity analysis
Comment on lines
+109
to
+112
# if not np.all(np.diff(train_index) > 0): | ||
# raise NotImplementedError('Invalid sample split. Only sorted train indices are supported.') | ||
# if not np.all(np.diff(test_index) > 0): | ||
# raise NotImplementedError('Invalid sample split. Only sorted test indices are supported.') |
Check notice
Code scanning / CodeQL
Commented-out code
This comment appears to contain commented-out code.
slightly reduce number of unit test for lpq
@@ -147,6 +147,8 @@ | |||
self._trimming_threshold = trimming_threshold | |||
_check_trimming(self._trimming_rule, self._trimming_threshold) | |||
|
|||
self._sensitivity_implemented = True |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
Assignment overwrites attribute _sensitivity_implemented, which was previously defined in superclass [DoubleML](1).
@@ -147,6 +147,8 @@ | |||
self._trimming_threshold = trimming_threshold | |||
_check_trimming(self._trimming_rule, self._trimming_threshold) | |||
|
|||
self._sensitivity_implemented = True |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
Assignment overwrites attribute _sensitivity_implemented, which was previously defined in superclass [DoubleML](1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding sensitivity analysis to account for omitted variable bias to PLR, IRM, DID and DIDCS models based on Chernozhukov et al. (2022).
For each specific class the Riesz representer is implmented with method
_sensitivity_element_est()
to estimatesensitivity_elements
(see guide documentation Sensitivity Analysis doubleml-docs#142).Sensitivity analysis
sensitivity_analysis()
method (see guide or example documentation Sensitivity Analysis doubleml-docs#142).Contour plots via
sensitivity_plot()
(see guide or example documentation Sensitivity Analysis doubleml-docs#142).Comments
_utils_check
folderPR Checklist