-
Notifications
You must be signed in to change notification settings - Fork 94
Enable external_predictions for short model in benchmarks #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable external_predictions for short model in benchmarks #238
Conversation
Thanks @lucien1011. I really like this addition. Maybe you can change the default value to |
@SvenKlaassen Thanks for the comments. I will implement those accordingly and update this PR. |
@SvenKlaassen I have updated the PR with the following three items:
|
I will check the coverage on a different branch and then merge into |
Description
This pull request adds an optional input arguments
fit_args
to the functionsensitivity_benchmark
in the classDoubleML
. Most importantly, this addition will enable the usage ofexternal_predictions
when fitting short models for sensitivity analysis.The new argument has to be in a nested dictionary like this:
Reference to Issues or PRs
No related issues or PRs to my knowledge.
PR Checklist
Please fill out this PR checklist (see our contributing guidelines for details).