-
Notifications
You must be signed in to change notification settings - Fork 369
Swapped tabs for spaces. #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super easy CR: Clone this PR run "git diff -w 86aa6dd" (the last commit before this one) and that will tell you all of the changes that werent whitepace. |
Actually, I thought there was a way to do that from there web site too.
…-kevin
On Wed, Apr 27, 2022, 2:35 PM Matt Seil ***@***.***> wrote:
Super easy CR: Clone this PR
run "git diff -w 86aa6dd
<86aa6dd>"
(the last commit before this one) and that will tell you all of the changes
that werent whitepace.
—
Reply to this email directly, view it on GitHub
<#685 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO6PGZ7EWJUV7BCTEEXCPLVHGCIRANCNFSM5UP67UDA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Indeed. I'm too old. ^^Lists all the changes ignoring whitespace. |
kwwall
approved these changes
Apr 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You win the "easiest code review contest ever" contest.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's finally annoying me enough.
Can we agree to standardize on this? Git CAN be configured to ignore whitespace changes when investigating older changes but in general I'm quite tired of seeing mixed files all the time. Too much Python? Maybe.