Skip to content

Swapped tabs for spaces. #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Swapped tabs for spaces. #685

merged 1 commit into from
Apr 30, 2022

Conversation

xeno6696
Copy link
Collaborator

It's finally annoying me enough.

Can we agree to standardize on this? Git CAN be configured to ignore whitespace changes when investigating older changes but in general I'm quite tired of seeing mixed files all the time. Too much Python? Maybe.

@kwwall
Copy link
Contributor

kwwall commented Apr 27, 2022 via email

@xeno6696
Copy link
Collaborator Author

Super easy CR: Clone this PR

run "git diff -w 86aa6dd" (the last commit before this one) and that will tell you all of the changes that werent whitepace.

@kwwall
Copy link
Contributor

kwwall commented Apr 27, 2022 via email

@xeno6696
Copy link
Collaborator Author

xeno6696 commented Apr 27, 2022

Indeed. I'm too old.

this

^^Lists all the changes ignoring whitespace.

Copy link
Contributor

@kwwall kwwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You win the "easiest code review contest ever" contest.

@kwwall kwwall merged commit fe060f3 into ESAPI:develop Apr 30, 2022
@xeno6696
Copy link
Collaborator Author

You win the "easiest code review contest ever" contest.

DD7492FE-9D42-4F0D-AA5D-AF0E8BAD6779

@kwwall kwwall mentioned this pull request Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants