#674 expand Validator interface Javadoc based on DefaultValidator #704
Conversation
|
I did perform some additional small reformatting in DefaultValidator as the indentation was potentially confusing |
There was a problem hiding this comment.
Well first off @stevebosman-oc I would like to say superb job. Two thumbs up. None of things I commented on are showstoppers, and I was not trying to be nitpicky, but I did want to get them at least recorded somewhere. Please add a comment as to whether you want to address them or if you'd rather not. But I'm not going to immediately approve lest someone else do the merge and not give you an opportunity to make further changes based on my comments. As such, I'm just going to leave this as 'Comment' rather than 'Request changes' as I do not wish to have the perfect become the enemy of the good. But thanks again. I know this took a lot of work.
|
This was actually very useful and it really is appreciated. Thank you @stevebosman ! |
|
@stevebosman-oc - My bad. You did add the links for the AntiSamy project. For some reason, when I was going through, resolving the Code Review comments in GitHub, the link didn't show up. Anyway, thanks again for doing this and thanks to the @opencastsoftware team for allowing him to do so. |
Contributed on behalf of the @opencastsoftware open source team
This was larger than I initially expected. I have generated the javadoc for the two classes and read through it a couple of times, but I'm concerned I may have missed something obvious.