Issue 620 - Move public static final Strings and enum from DefaultSecurityConfiguration to PropNames #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved ESAPI propery variables ('public static final String') from DefaultSecurityConfiguration to here.
Moved DefaultSearchPath enum from DefaultSecurityConfiguration to here.
…the new PropNames class. Also some misc code cleanup such as removing extraneous whitespace at end of lines, etc.
jeremiahjstacey
approved these changes
May 30, 2022
|
@xeno6696 - Hey Matt, are you good with these changes (and in particular, the name of the new class)? Jeremiah approved them. Thanks for taking a look. |
|
No issues with anything here, though I did skip the handful of test classes with 500+ changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xeno6696 and @jeremiahjstacey - I didn't address the stuff in the email yet about
getDisableIntrusionDetection()yet, but OTOH, I didn't un-deprecate it, so we still have time to work on that as there still are a bunch of deprecations to deal with besides that one. I just didn't want to spend ALL holiday working on this so not going to let the perfect become the enemy of the good here.