Skip to content

Preparation for ESAPI 2.5.3.0 release #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 23, 2023
Merged

Preparation for ESAPI 2.5.3.0 release #809

merged 17 commits into from
Nov 23, 2023

Conversation

kwwall
Copy link
Contributor

@kwwall kwwall commented Nov 20, 2023

  • Update to AntiSamy 1.7.4
  • Javadoc fixes / updates / improvements
  • Revise ESAPI's deprecation policy
  • Change ESAPI's default key size for digital signatures from 1024-bits to 2048-bits.
  • Add 'noopenerAndNoreferrerAnchors' AntiSamy directive for anchor tags.
  • Deprecate both Validator.isValidSafeHTML interfaces; to be removed in 1 year after ESAPI 2.5.3.0 release.
  • Revise / reorganize JUnit tests using deprecated isValidSafeHTML methods.

kwwall added 11 commits October 13, 2023 22:16
@kwwall
Add 'noopenerAndNoreferrerAnchors' AntiSamy directive for anchor tags.
8c4ffcc
@kwwall
Change ESAPI's defaults for digital signature from 1024-bit SHA1withD…
f39d769 
…SA to 2048-bit SHA256withDSA.
@kwwall
Change ESAPI's default key size for digital signature from 1024-bits …
ad5e64b 
…to 2048-bits.
@kwwall
Extensive Javadoc improvements.
7dd6d44
@kwwall
Changes to update to AntiSamy 1.7.4 and other minor changes.
f624723
@kwwall
Revise ESAPI's deprecation policy.
322f201
@kwwall
Deprecate both isValidSafeHTML methods and note they will be removed …
1e44dd0 
…1 year after the official ESAPI 2.5.3.0 release.
@kwwall
Revise JUnit tests using Validator.isValidSafeHTML.
95c57b4
@kwwall
Fix Javadoc tag.
44b30a4
@kwwall
Another Javadoc tag fix.
f959b04
@kwwall
Last Javadoc fix. It would be nice if 'mvn site' reported all the err…
3dc855c 
…ors at once.
This was referenced Nov 20, 2023
Closed
Merged
This was referenced Nov 20, 2023
Closed
Closed
xeno6696
xeno6696 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@xeno6696 xeno6696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward enough.

@xeno6696
Copy link
Collaborator

Sorry I thought I was just approving the first commit. Walking through the changes today.

@xeno6696
Copy link
Collaborator

I approve, I will wait until EOB for @jeremiahjstacey to take a pass, but this seems mostly routine with just some new tests.

@kwwall
Copy link
Contributor Author

kwwall commented Nov 22, 2023

Okay. I will wait until 7pm ET today until I merge this to give @jeremiahjstacey the opportunity to approve this PR. Of it he doesn't intend reviewing this PR, until he communicates that via a comment in this PR or an email to me.

@jeremiahjstacey
Copy link
Collaborator

All looks good to me. Sorry for the delay.
I appreciate the smaller scoped tests and all the accompanying comments.

@kwwall
Copy link
Contributor Author

kwwall commented Nov 23, 2023

@jeremiahjstacey wrote:

All looks good to me. Sorry for the delay. I appreciate the smaller scoped tests and all the accompanying comments.

No worries. It's all good. Just want to get this out the door while I'm on PTO / Holiday.

@kwwall kwwall merged commit 7d4dd5a into ESAPI:develop Nov 23, 2023
@kwwall kwwall deleted the 2.5.3.0-prep branch November 30, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeno6696 xeno6696 xeno6696 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwwall @xeno6696 @jeremiahjstacey