-
Notifications
You must be signed in to change notification settings - Fork 368
Fix Typos #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix Typos #852
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
bb535b8
Update README.md
DarioViva42 06e4054
EncodingPatternPreservation: fix typo
DarioViva42 86081e1
AbstractCodec: fix typo
DarioViva42 0c832d9
AbstractCodec: there is no such thing as a footgun usage
DarioViva42 a406150
AbstractPushbackSequence: fix typo. see https://languagetool.org/insi…
DarioViva42 5bb34ac
Base64: fix typo
DarioViva42 6d4aebe
HashTrie: fix typo
DarioViva42 00c3a31
HashTrie: fix typo
DarioViva42 63c81bf
HTMLEntityCodec: fix typo
DarioViva42 64d77a0
MySQLCodec: fix typo
DarioViva42 d79014e
MySQLCodec: fix typo
DarioViva42 43b4248
PushBackSequenceImpl: fix typo
DarioViva42 c9c0388
PushbackString: fix typo
DarioViva42 18c8e51
EsapiConfiguration: fix typo
DarioViva42 1e08fe1
AbstractPrioritizedPropertyLoader: fix typo
DarioViva42 e698dd1
AbstractPrioritizedPropertyLoader: fix grammar
DarioViva42 7b43092
CipherText: fix typo
DarioViva42 15d9b54
CipherTextSerializer: fix typo
DarioViva42 08c2ab3
CryptoHelper: fix typo
DarioViva42 5c9e2f9
CryptoHelper: fix typo
DarioViva42 8933ab8
CryptoHelper: fix grammar
DarioViva42 e064ba1
CryptoToken: fix typo
DarioViva42 cad8526
CryptoToken: fix typo
DarioViva42 7f44b8e
PlainText: fix typo
DarioViva42 c4d4140
RequestRateThrottleFilter: fix typo
DarioViva42 aed6851
SecurityWrapperRequest: fix typo
DarioViva42 e3be962
CompositeLogScrubber: fix typo
DarioViva42 26ae2f6
JavaLogBridge: fix typo
DarioViva42 82be8ba
Authenticator: fix typo
DarioViva42 1ff4331
Encoder: fix typo
DarioViva42 f5e138c
Encryptor: untangle unclear sentence
DarioViva42 7175212
ESAPI: fix typo
DarioViva42 8924260
HTTPUtilities: fix typo
DarioViva42 a4206af
HTTPUtilities: fix typo
DarioViva42 a588a05
Logger: fix typo
DarioViva42 faa767a
Logger: fix typo
DarioViva42 1aabcf9
SecurityConfiguration: fix typo
DarioViva42 53fecf7
StringUtilities: correct javadoc
DarioViva42 1dea416
User: fix typo
DarioViva42 9978af6
Validator: fix typo
DarioViva42 b685e3c
Validator: fix typo
DarioViva42 42efa15
CollectionsUtil: fix typo
DarioViva42 e0e63cb
ObjFactory: fix typo
DarioViva42 cfcfa0d
EncodeForBase64Tag: fix typo
DarioViva42 b692d83
EncodeForCSSTag: fix typo
DarioViva42 f8a2d02
EncodeForHTMLAttributeTag: fix typo
DarioViva42 698fd2a
EncodeForHTMLTag: fix typo
DarioViva42 aec18fb
EncodeForJavaScriptTag: fix typo
DarioViva42 66ab977
EncodeForURLTag: fix typo
DarioViva42 fbc54f9
EncodeForVBScriptTag: fix typo
DarioViva42 66135c8
EncodeForXMLAttributeTag: fix typo
DarioViva42 b0ef12b
EncodeForXMLTag: fix typo
DarioViva42 0b1c09d
EncodeForXPathTag: fix typo
DarioViva42 f2fbbfd
AbstractAccessReferenceMap: fix typo
DarioViva42 cbac2c8
StringUtilities: replaceNull: rephrase javadoc using @code
DarioViva42 57f30d8
Encryptor: decrypt: fix typo, use expression from before f5e138c8c154…
DarioViva42 53000ff
User: setLastFailedLoginTime: use "authenticate" instead of "log in"
DarioViva42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ | |
* and do not have extensive support for the various implementation languages which ESAPI | ||
* supports. (Perhaps wishful thinking that other ESAPI implementations such as | ||
* ESAPI for .NET, ESAPI for C, ESAPI for C++, etc. will all support a single, common | ||
* serialization technique so they could exchange encrypted data.) | ||
* serialization technique, so they could exchange encrypted data.) | ||
* | ||
* @author [email protected] | ||
* @since 2.0 | ||
|
@@ -207,7 +207,7 @@ private byte[] computeSerialization(int kdfInfo, long timestamp, | |
|
||
// All strings are written as UTF-8 encoded byte streams with the | ||
// length prepended before it as a short. The prepended length is | ||
// more for the benefit of languages like C so they can pre-allocate | ||
// more for the benefit of languages like C, so they can pre-allocate | ||
// char arrays without worrying about buffer overflows. | ||
private void writeString(ByteArrayOutputStream baos, String str) { | ||
byte[] bytes; | ||
|
@@ -405,7 +405,7 @@ private CipherText convertToCipherText(byte[] cipherTextSerializedBytes) | |
// Fixed in ESAPI crypto version 20130839. Previously is didn't really matter | ||
// because there was only one version (20110203) and it defaulted to that | ||
// version, which was the current version. But we don't want that as now there | ||
// are two versions and we could be decrypting data encrypted using the previous | ||
// are two versions, and we could be decrypting data encrypted using the previous | ||
// version. | ||
ct.setKDF_PRF(kdfPrf); | ||
ct.setKDFVersion(kdfVers); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll let this pass, but this sort of comment is not "public" in the sense that it's not going to end up in generated Javadoc. One of my reasons wanting to separate this type of comment from Javadoc comments is that we don't need to scrutinize these as much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sh*t, I have cherry picked my way through all the commits and went through them again a second time, dropping all of them that did not match your criteria. This one commit must have slipped through. That was not my intention, and if you want, I can revert this commit again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine. There's only a few of those here and I reviewed them all. In your original PR there were a lot of these types, and I'm just saying as a rule, I really don't care that much if those "internal comments" are ever fixed unless they are flat out misleading (e.g., like they left out a 'not') so the logic of the comment is reversed or no one can really understand what the comment meant. But only people working on ESAPI code itself generally pay attention to that code. So, really low priority to fix these.