[generator] support input field deprecation #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With recent GraphQL spec changes, deprecation should be supported on fields, input fields (new), arguments (new) and enum values. This change adds the support for deprecating input fields. Argument deprecation is not supported as Kotlin `@Deprecated` is not applicable to parameters. See https://youtrack.jetbrains.com/issue/KT-25643
dariuszkuc
added
type: enhancement
samuelAndalon
approved these changes
Feb 14, 2022
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
With recent GraphQL spec changes, deprecation should be supported on fields, input fields (new), arguments (new) and enum values. This change adds the support for deprecating input fields. Argument deprecation is not supported as Kotlin `@Deprecated` is not applicable to parameters. See https://youtrack.jetbrains.com/issue/KT-25643
dariuszkuc
pushed a commit
that referenced
this pull request
Mar 12, 2025
…ed (#2075) ### 📝 Description This PR enables support for using the `@GraphQLDeprecated` annotation on arguments, allowing the generated GraphQL schema to include the `@deprecated` directive. #### Changes: - Updated `generateArgument.kt ` to mark argument as deprecated if the DeprecationReason is present. - Added tests to validate the correct behavior when marking arguments as deprecated. #### Why? The GraphQL spec now officially supports applying `@deprecated` on arguments, enabling better API evolution without breaking existing clients. This change aligns the library with the latest spec, giving developers a built-in way to signal argument deprecations. - [GraphQL Spec - Deprecated Arguments](https://spec.graphql.org/October2021/#sec--deprecated) ](https://spec.graphql.org/draft/#sec--deprecated) ### 🔗 Related Issues #1361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
With recent GraphQL spec changes, deprecation should be supported on fields, input fields (new), arguments (new) and enum values. This change adds the support for deprecating input fields.
Argument deprecation is not supported as Kotlin
@Deprecatedis not applicable to parameters.🔗 Related Issues
See https://youtrack.jetbrains.com/issue/KT-25643