feat: support argument types without primaryConstructor #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Aug 15, 2022
...nerator/src/main/kotlin/com/expediagroup/graphql/generator/execution/convertArgumentValue.kt
Outdated
Show resolved
Hide resolved
|
Theoretically we could use reflection and attempt to match input map against properties on the object (this is what jackson does) but unsure if we should do it. |
|
i think for ppl using classes without primary constructor, the effort of adding a constructor would be minimal, if we start adding support for matching properties without a constructor we would need to check several use cases ? |
|
Yes, matching properties is non trivial - you would need to most likely account for setters and follow Java Beans naming conventions. It would allow folks to use Java objects but we never targeted that compatibility so I am unsure whether it is worth the effort. |
samuelAndalon
added
changes: minor
dariuszkuc
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
there are some use cases where no primary constructor will be defined, like in java classes, for those cases if no primaryConstructor is found use the first element on the constructors list, otherwise throw the error
🔗 Related Issues
#1515