Make nullable parameters always optional #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat nullable parameters that have no default value as if their default was set to null. Nullable parameters that have a default value explicitly set will continue to use that as their default.
| parameter.type.isOptionalInputType() || | ||
|
|
||
| // for nullable parameters that have no explicit default, we pass in null if not in input | ||
| (parameter.type.isMarkedNullable && !parameter.isOptional) |
There was a problem hiding this comment.
probably worth to wrap this expression in an extension function in kParameterExtensions,
KParameter.isNotOptionalNullable()
| @@ -109,7 +109,11 @@ private fun <T : Any> mapToKotlinObject(input: Map<String, *>, targetClass: KCla | |||
| // filter parameters that are actually in the input in order to rely on parameters default values | |||
| // in target constructor | |||
| val constructorParametersInInput = constructorParameters.filter { parameter -> | |||
There was a problem hiding this comment.
we will probably need to rename this
we can just call it constructorParameters, and do
val constructorParameters = targetConstructor.parameters.filter { ... }
|
Thanks for the PR, i left couple of minor comments |
- add KParameter.isNotOptionalNullable() - minor cleanups in mapToKotlinObject
samuelAndalon
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Treat nullable parameters that have no default value as if their default was set to null.
Nullable parameters that have a default value explicitly set will continue to use that as their default.
🔗 Related Issues
#1527