Backport _FieldSet Federation v2 fix to 6.x.x branch
#1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [federation] rename _FieldSet to FieldSet in Federation v2 Per [Apollo Specification](https://www.apollographql.com/docs/federation/federation-spec), `_FieldSet` was renamed to `FieldSet` in Federation v2. Resolves: #1512 * ktlint - unused imports
|
Hello, thank you for the contribution!, for the documentation changes you would need a follow up PR against master updating |
|
Hey @samuelAndalon, it appears they are already updated in
|
samuelAndalon
approved these changes
Dec 16, 2022
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Jan 17, 2023
This was fixed in ExpediaGroup#1593 and broken again in ExpediaGroup#1618.
dariuszkuc
added a commit
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Currently, the schema generation in 6.3.2 will generate an invalid output containing a
_FieldSetscalar instead ofFieldSet. Such a schema will be rejected by Apollo Studio.🔗 Related Issues