Skip to content

Add example of subquery #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Add example of subquery #171

merged 1 commit into from
Feb 22, 2019

Conversation

gscheibel
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage     97.89%   97.89%           
  Complexity      153      153           
=========================================
  Files            55       55           
  Lines           523      523           
  Branches         90       90           
=========================================
  Hits            512      512           
  Misses            7        7           
  Partials          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248869d...b647062. Read the comment docs.

@d4rken
Copy link
Contributor

d4rken commented Feb 20, 2019

What do you think about including the schema that is generated by the examples within the file as comment?

@smyrick smyrick added the type: documentation Documentation or test changes label Feb 20, 2019
@smyrick
Copy link
Contributor

smyrick commented Feb 22, 2019

@gscheibel Made a good comment that the example app is meant to be run so the resulting schema can easily be looked at in graphiQL, which is a little easier too.

I am going to merge. If we want to add more docs on what code will produce a schema we can do that in the wiki. I wouldn't expect anyone to look through the code for these comments.

@smyrick smyrick merged commit 0658380 into master Feb 22, 2019
@smyrick smyrick deleted the subquery branch February 22, 2019 18:33
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

3 participants