Skip to content

fix: remove directive duplication in the generator #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2019
Merged

fix: remove directive duplication in the generator #176

merged 1 commit into from
Feb 25, 2019

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Feb 25, 2019

Before:
screen shot 2019-02-25 at 12 03 29 am

After:
screen shot 2019-02-25 at 12 00 02 am

@smyrick smyrick added type: bug Something isn't working changes: patch Changes require a patch version labels Feb 25, 2019
@codecov
Copy link

codecov bot commented Feb 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@193871a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #176   +/-   ##
=========================================
  Coverage          ?   98.14%           
  Complexity        ?      158           
=========================================
  Files             ?       55           
  Lines             ?      540           
  Branches          ?       92           
=========================================
  Hits              ?      530           
  Misses            ?        7           
  Partials          ?        3
Impacted Files Coverage Δ Complexity Δ
...ia/graphql/generator/types/DirectiveTypeBuilder.kt 100% <100%> (ø) 7 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193871a...550f98f. Read the comment docs.

@dariuszkuc dariuszkuc merged commit 2928c8c into ExpediaGroup:master Feb 25, 2019
@smyrick smyrick deleted the directive-duplication branch February 25, 2019 17:37
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@smyrick @dariuszkuc
fix: remove directive duplication in the generator (ExpediaGroup#176)
6748548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszkuc dariuszkuc dariuszkuc approved these changes

Assignees
No one assigned
Labels
changes: patch Changes require a patch version type: bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smyrick @dariuszkuc