chore: fix flaky subscription test #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add artificial delay to Ktor subscription test to ensure coroutines can complete successfully within the timeout.
samuelAndalon
approved these changes
Jun 2, 2023
dariuszkuc
added a commit
that referenced
this pull request
Jun 2, 2023
This reverts commit 8c66da3.
dariuszkuc
added a commit
that referenced
this pull request
Jun 2, 2023
Reverts #1787 While actions running the PR checks worked it still fails on master :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add artificial delay to Ktor subscription test to ensure coroutines can complete successfully within the timeout.
🔗 Related Issues