Don't Merge: Attempt to Update Gradle, Kotlin, and Libraries #1803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to make a contribution to your project by upgrading Kotlin, Gradle, and such. I went through and carefully updated the dependencies and made some other changes due to deprecations and broken APIs.
However, when it came to ktlint, that is where things went downhill. It seems that ktlint was never fully working in this project originally as there are potentially hundreds of formatting errors that don't comply with the ktlint standards. I don't know how you would want to fix this as there are a lot of formatting and naming anomalies in the code. You may just want to disable ktlint altogether. I tried to disable a few rules but there are just a lot of code formatting problems in general.
Also, the
graphql-kotlin-client-generator
Integration Tests are failing and there doesn't seem to be much in the way of helpful error messages.I hope you may find the work I did here helpful, but I feel that the project maintainers should take it from here. Thank you for your efforts with
graphql-kotlin
!