Skip to content

Don't Merge: Attempt to Update Gradle, Kotlin, and Libraries #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

murphye
Copy link

@murphye murphye commented Jun 25, 2023

I attempted to make a contribution to your project by upgrading Kotlin, Gradle, and such. I went through and carefully updated the dependencies and made some other changes due to deprecations and broken APIs.

However, when it came to ktlint, that is where things went downhill. It seems that ktlint was never fully working in this project originally as there are potentially hundreds of formatting errors that don't comply with the ktlint standards. I don't know how you would want to fix this as there are a lot of formatting and naming anomalies in the code. You may just want to disable ktlint altogether. I tried to disable a few rules but there are just a lot of code formatting problems in general.

Also, the graphql-kotlin-client-generator Integration Tests are failing and there doesn't seem to be much in the way of helpful error messages.

I hope you may find the work I did here helpful, but I feel that the project maintainers should take it from here. Thank you for your efforts with graphql-kotlin!

@dariuszkuc
Copy link
Collaborator

Thanks for the PR and looking into the ktlint stuff! I am unsure how much value we get out of ktlint so maybe it does makes sense to just drop it altogether.

re: gradle8 update -> I got the PR#1726 opened already
re: kotlin update -> we are currently blocked on the update to 1.8.22 as we need a compatible version of https://github.com/tschuchortdev/kotlin-compile-testing lib (this is what is causing the failures in the client generator -> we use it in our unit tests to compile generated code and kotlin compiler version has to match kotlin version used in the project)

@dariuszkuc
Copy link
Collaborator

superseded by #1822

@dariuszkuc dariuszkuc closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants